Skip to content

hide exposure compensation for fixed exposure #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 18, 2020
Merged

hide exposure compensation for fixed exposure #535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
580f6e6
hide exposure compensation for fixed exposure
sebastienlagarde May 18, 2020
ee6ca88
Update PostProcessSystem.cs
sebastienlagarde May 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion com.unity.render-pipelines.high-definition/Editor/PostProcessing/ExposureEditor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ public override void OnInspectorGUI()
else if (mode == (int)ExposureMode.Fixed)
{
PropertyField(m_FixedExposure);
PropertyField(m_Compensation);
}
else
{
Expand Down
3 changes: 2 additions & 1 deletion com.unity.render-pipelines.high-definition/Runtime/PostProcessing/PostProcessSystem.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -809,7 +809,8 @@ void DoFixedExposure(CommandBuffer cmd, HDCamera camera)
if (m_Exposure.mode.value == ExposureMode.Fixed)
{
kernel = cs.FindKernel("KFixedExposure");
cmd.SetComputeVectorParam(cs, HDShaderIDs._ExposureParams, new Vector4(m_Exposure.compensation.value + m_DebugExposureCompensation, m_Exposure.fixedExposure.value, 0f, 0f));
// Don't apply exposure compensation on fixed exposure in 7.4.0 to not break existing users project
cmd.SetComputeVectorParam(cs, HDShaderIDs._ExposureParams, new Vector4(0f /* m_Exposure.compensation.value + m_DebugExposureCompensation */, m_Exposure.fixedExposure.value, 0f, 0f));
}
else if (m_Exposure.mode == ExposureMode.UsePhysicalCamera)
{
Expand Down