Skip to content

Conversation

alex-vazquez
Copy link
Contributor

@alex-vazquez alex-vazquez commented Aug 19, 2021

Purpose of this PR

Improving light inspectors across SRP's. Sharing styles between pipelines.


Testing status

Check the tooltips and labels


Comments to reviewers

Notes for the reviewers you have assigned.

@alex-vazquez alex-vazquez self-assigned this Aug 19, 2021
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_2021.2

URP
/.yamato%252Fall-urp.yml%2523PR_URP_2021.2

SRP Core
You could run ABV on your branch before merging your PR, but it will start A LOT of jobs. Please be responsible about it and run it only when you feel the PR is ready:
/.yamato%252F_abv.yml%2523all_project_ci_2021.2
Be aware that any modifications to the Core package impacts everyone in the Graphics repo so please discuss the PR with your lead.

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

Copy link
Contributor

@martint-unity martint-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@alex-vazquez alex-vazquez marked this pull request as ready for review August 26, 2021 07:38
@alex-vazquez alex-vazquez requested review from a team as code owners August 26, 2021 07:38
@alex-vazquez
Copy link
Contributor Author

alex-vazquez commented Aug 30, 2021

@Unity-Technologies/gfx-qa-urp @Unity-Technologies/gfx-qa-hdrp , please have a quick look at the tooltips and the labels of the light temperature

@alex-vazquez alex-vazquez requested a review from a team August 30, 2021 14:53
@RemyUnity
Copy link
Contributor

Shouldn't this be mentioned in the changelog ?

@alex-vazquez
Copy link
Contributor Author

@RemyUnity , I am missing my last PR where I will put all the changelog for this.

Copy link
Contributor

@JMargevics JMargevics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Checked labels and tooltips on both HDRP and URP lights. All tooltips and labels appear correctly. Saw no issues with light temperature section either. ✔

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alex-vazquez alex-vazquez merged commit 4b19dd1 into master Sep 6, 2021
@alex-vazquez alex-vazquez deleted the x-pipeline/light-inspector-improvements-step2 branch September 6, 2021 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants