-
Notifications
You must be signed in to change notification settings - Fork 856
XPipeline - Sharing styles across Light Inspectors #5402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XPipeline - Sharing styles across Light Inspectors #5402
Conversation
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. HDRP URP SRP Core Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one!
@Unity-Technologies/gfx-qa-urp @Unity-Technologies/gfx-qa-hdrp , please have a quick look at the tooltips and the labels of the light temperature |
Shouldn't this be mentioned in the changelog ? |
@RemyUnity , I am missing my last PR where I will put all the changelog for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Checked labels and tooltips on both HDRP and URP lights. All tooltips and labels appear correctly. Saw no issues with light temperature section either. ✔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose of this PR
Improving light inspectors across SRP's. Sharing styles between pipelines.
Testing status
Check the tooltips and labels
Comments to reviewers
Notes for the reviewers you have assigned.