Skip to content

Conversation

jenniferd-unity
Copy link
Contributor

@jenniferd-unity jenniferd-unity commented Aug 25, 2021


Purpose of this PR

The Linux edit mode tests are failing at the moment on Global Settings tests.
When debugging on a VM machine, I noticed that OpenGL Core was the used Graphics API which is not compatible with HDRP, Vulkan should be changed. This PR enforces Vulkan usage for the Editor (-force-vulkan commandline is only forcing the Player/Play mode).
More info on slack here


Testing status

On bokken, I tested with both Editor open and with command line to run HDRP_Tests. They all were green.

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@jenniferd-unity jenniferd-unity self-assigned this Aug 26, 2021
@jenniferd-unity jenniferd-unity marked this pull request as ready for review August 26, 2021 09:20
@jenniferd-unity jenniferd-unity merged commit 17cf832 into master Aug 26, 2021
@jenniferd-unity jenniferd-unity deleted the HDRP/fix-linux-build branch August 26, 2021 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants