-
Notifications
You must be signed in to change notification settings - Fork 856
Do not recompile the VFX when property min/max value change #5514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not recompile the VFX when property min/max value change #5514
Conversation
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. VFX Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks neat! Tested:
- Slider in Blackboard and Inspector of exposed property on vfx (float, arcshapes (+gizmos))
- Auto compilation/manual compilation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, the usage of settings invalidation only when it's need is more elegant.
Thanks for the fix.
…max-change' into vfx/fix/1307648-recompile-on-minmax-change
Purpose of this PR
https://fogbugz.unity3d.com/f/cases/1307648/
The VFX Graph get recompile every time the min or max values of a property is changed

Testing status
I tested the scenario described in the fogbugz
Comments to reviewers
When number property is set as a range the user can manipulate a slider to pick a value.
This slider has a minimum and a maximum value.
While testing I notice a few annoying behaviors related to this: