Skip to content

Conversation

julienamsellem
Copy link
Contributor

Purpose of this PR

https://fogbugz.unity3d.com/f/cases/1307648/

The VFX Graph get recompile every time the min or max values of a property is changed
Compiling-issue


Testing status

I tested the scenario described in the fogbugz


Comments to reviewers

When number property is set as a range the user can manipulate a slider to pick a value.
This slider has a minimum and a maximum value.
While testing I notice a few annoying behaviors related to this:

  • ❌When the mode is switched to "Range" the min, max and value get the same value
  • ❌The user can easily set a minimum > maximum or the opposite, nothing is done against that
  • ✅When changing the min or the max value the value is set to the max

@github-actions
Copy link

github-actions bot commented Sep 2, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

VFX
/.yamato%252Fall-vfx.yml%2523PR_VFX_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@VitaVFX VitaVFX requested review from VitaVFX and removed request for a team September 2, 2021 16:39
Copy link

@VitaVFX VitaVFX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks neat! Tested:

  • Slider in Blackboard and Inspector of exposed property on vfx (float, arcshapes (+gizmos))
  • Auto compilation/manual compilation

@julienamsellem julienamsellem marked this pull request as ready for review September 6, 2021 07:50
Copy link
Contributor

@PaulDemeulenaere PaulDemeulenaere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, the usage of settings invalidation only when it's need is more elegant.
Thanks for the fix.

@julienamsellem julienamsellem merged commit d4c2f95 into master Sep 13, 2021
@julienamsellem julienamsellem deleted the vfx/fix/1307648-recompile-on-minmax-change branch September 13, 2021 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants