Skip to content

Conversation

Nzollner
Copy link
Contributor

Purpose of this PR

This is a backport of this PR adding multi-edit to the UniversalRenderPipelineAsset.

image


Testing status

This is only a UI change and because of that, I have not started any testing since there should be no changes to the result.

I have tested the multi-edit on my laptop(Windows 10, using DX11).
I tested the multi-edit by checking if I could change the values and if the values change affected the view and if the actions were undoable which they were.


Comments to reviewers

When you test this check if the values work as expected and if the changes correspond to the visual changes which should be applied with the changed values.

@Nzollner Nzollner requested a review from a team as a code owner September 17, 2021 08:20
@alex-vazquez alex-vazquez changed the base branch from master to 2021.1/staging September 17, 2021 08:21
@alex-vazquez alex-vazquez requested review from a team as code owners September 17, 2021 08:21
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_trunk
With changes to HDRP packages, you should also run
/.yamato%252Fall-lightmapper.yml%2523PR_LightMapper_trunk

URP
/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/.yamato%252Fall-lightmapper.yml%2523PR_LightMapper_trunk

Shader Graph
/.yamato%252Fall-shadergraph.yml%2523PR_ShaderGraph_trunk
Depending on your PR, you may also want
/.yamato%252Fall-shadergraph_builtin_foundation.yml%2523PR_ShaderGraph_BuiltIn_Foundation_trunk
/.yamato%252Fall-shadergraph_builtin_lighting.yml%2523PR_ShaderGraph_BuiltIn_Lighting_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@Nzollner Nzollner merged commit 2b5667f into 2021.1/staging Sep 17, 2021
@Nzollner Nzollner deleted the 2021.1/universal/bugfix/multiedit branch September 17, 2021 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants