Skip to content

Conversation

julienamsellem
Copy link
Contributor

Purpose of this PR

Backport of this PR: #5597
Fogbugz: https://fogbugz.unity3d.com/f/cases/1315493/


Testing status

Tested on the branch staging/2021.2 locally


Comments to reviewers

Notes for the reviewers you have assigned.

@github-actions github-actions bot added the vfx label Sep 20, 2021
@julienamsellem julienamsellem marked this pull request as ready for review September 20, 2021 08:45
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

VFX
/.yamato%252Fall-vfx.yml%2523PR_VFX_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

Copy link
Contributor

@PaulDemeulenaere PaulDemeulenaere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I compared changed from the root PR, they are identical (and changelog correctly merged)
LGTM! 🟢
Thanks for the fix.

@julienamsellem julienamsellem merged commit aa767e3 into 2021.2/staging Sep 20, 2021
@julienamsellem julienamsellem deleted the 2021.2/vfx/fix/1315493-missing-past-menu-backport branch September 20, 2021 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants