[VFX] Fix Simulate (to 2021.2) #6186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 41c8660 Merge: 4661eb0 62499d9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Oct 29 09:28:17 2021 +0200 Merge branch 'master' into vfx/test/1355385-simulate-issue-repro commit 4661eb0 Merge: f42d0c1 ac2773c Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Oct 18 11:04:35 2021 +0200 Merge branch 'master' into vfx/test/1355385-simulate-issue-repro commit f42d0c1 Merge: 3529433 840b26e Author: Paul Demeulenaere <pauld@unity3d.com> Date: Sat Oct 2 17:22:51 2021 +0200 Merge branch 'master' into vfx/test/1355385-simulate-issue-repro commit 3529433 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Sep 27 17:17:30 2021 +0200 *Update missing image reference on OSX + missung meta commit 9ebd4f9 Merge: 9607671 9a6aa50 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Sep 27 09:30:16 2021 +0200 Merge branch 'master' into vfx/test/1355385-simulate-issue-repro commit 9607671 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Sep 27 09:03:24 2021 +0200 *Update reference image commit 0e58e93 Merge: d3c506d 11417d3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Sep 24 21:38:57 2021 +0200 Merge branch 'master' into vfx/test/1355385-simulate-issue-repro commit d3c506d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Sep 22 16:01:46 2021 +0200 *Improve test coverage commit a260ef2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Sep 22 08:58:14 2021 +0200 *Update image reference retrieving result from yamato Some platform still missing commit a1ca73b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Sep 21 20:34:22 2021 +0200 *Update scene test & GraphicTest commit 4c7ad38 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Sep 21 17:36:31 2021 +0200 *Update test location commit e1a0c0f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Sep 21 13:16:21 2021 +0200 Force sorting for a better coverage commit 80781f5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Sep 20 16:19:10 2021 +0200 *Add Simulate test & improve custom prewarm commit 368239b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Sep 20 15:34:25 2021 +0200 *Update test scene commit c0159d5 Merge: 68e7766 9fd657c Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Sep 17 17:27:47 2021 +0200 Merge branch 'master' into vfx/test/1355385-simulate-issue-repro # Conflicts: # TestProjects/VisualEffectGraph_URP/ProjectSettings/EditorBuildSettings.asset commit 68e7766 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Sep 15 18:17:14 2021 +0200 *Add repro test
gabrieldelacruz
approved these changes
Nov 15, 2021
|
The expected change landed in 2021.2.10f1 |
PaulDemeulenaere
deleted the
2021.2/vfx/test/1355385-simulate-issue-repro
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Backport of #5758⚠️ )
Relative to C++ change in https://ono.unity3d.com/unity/unity/pull-request/135475/_/2021.2/graphics/vfx/fix/1355385-force-flush-after-simulate (must wait and be synchronized
Testing status
_testing_vfx_simulate_21_2.mp4
Yamato 🟢
Yamato internal
Comments to reviewers
N/A