-
Notifications
You must be signed in to change notification settings - Fork 855
[URP][case 1348209] fix for gray thumbnails #5778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. URP Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for clear description and images!
In addition, I have also manually tested the URP template and upgradability from built-in to URP. Thumbnails are visible.
# Conflicts: # com.unity.render-pipelines.universal/CHANGELOG.md
The tests that were failing also fails on Nightly tests so shouldn't be anything this PR introduces. |
Purpose of this PR
Fixing gray thumbnails issue here https://fogbugz.unity3d.com/f/cases/1348209/
Before: The thumbnails didn't really render correctly and were only gray squares.

After:

Testing status
Opened a new template scene and tested it.
Comments to reviewers
Notes for the reviewers you have assigned.