Skip to content

Conversation

martint-unity
Copy link
Contributor


Purpose of this PR

backport of this #5778
here is the FB case https://fogbugz.unity3d.com/f/cases/1367634/


Testing status

Tested by manually import all and see that the backgrounds now are fixed for the thumbnails.
Running Yamato


Comments to reviewers

Notes for the reviewers you have assigned.

@martint-unity martint-unity requested a review from phi-lira October 5, 2021 09:46
@martint-unity martint-unity requested review from a team as code owners October 5, 2021 09:46
@github-actions
Copy link

github-actions bot commented Oct 5, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/.yamato%252Fall-urp.yml%2523PR_URP_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions
Copy link

github-actions bot commented Oct 5, 2021

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

Copy link
Contributor

@erikabar erikabar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, approved without additional testing

@martint-unity martint-unity merged commit f77d42a into 2021.2/staging Oct 6, 2021
@martint-unity martint-unity deleted the 2021.2/universal/backport/fix-gray-asset-thumbnails branch October 6, 2021 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants