Skip to content

Conversation

jessebarker
Copy link
Contributor

@jessebarker jessebarker commented Sep 29, 2021

Purpose of this PR

This PR fixes https://fogbugz.unity3d.com/f/cases/1366200/

The recent updates to fix https://fogbugz.unity3d.com/f/cases/1337137/ do not handle the possibility that a subgraph might have duplicate input or output slots. This largely never happens as the actual ShaderGraph UI (graph editor) does not permit it. However, it is possible that some custom user assets may fall into this category. We should detect this situation, warn the user that they have an unsupported subgraph, and tell them how to update their subgraphs so that they work properly.

Here is an example of the console output the user would see (based on the repro project):
Screen Shot 2021-09-29 at 4 29 07 PM


Testing status

Manual testing according to the repro steps in the bug.

N.b., On this Yamato run, the bokken farm was having certificate issues on the OSX agent (also present on master at branch-off for this PR)

Comments to reviewers

Notes for the reviewers you have assigned.

    - Give the user details on how to update their project to fix the situation.
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

Shader Graph
/.yamato%252Fall-shadergraph.yml%2523PR_ShaderGraph_trunk
Depending on your PR, you may also want
/.yamato%252Fall-shadergraph_builtin_foundation.yml%2523PR_ShaderGraph_BuiltIn_Foundation_trunk
/.yamato%252Fall-shadergraph_builtin_lighting.yml%2523PR_ShaderGraph_BuiltIn_Lighting_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@jessebarker jessebarker marked this pull request as ready for review September 30, 2021 20:18
@jessebarker jessebarker requested a review from a team as a code owner September 30, 2021 20:18
@jessebarker jessebarker merged commit 61a9b82 into master Oct 1, 2021
@jessebarker jessebarker deleted the sg-fix-1366200 branch October 1, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants