[ShaderGraph][2022.1] Detect duplicate subgraph input/output slots #5852
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR fixes https://fogbugz.unity3d.com/f/cases/1366200/
The recent updates to fix https://fogbugz.unity3d.com/f/cases/1337137/ do not handle the possibility that a subgraph might have duplicate input or output slots. This largely never happens as the actual ShaderGraph UI (graph editor) does not permit it. However, it is possible that some custom user assets may fall into this category. We should detect this situation, warn the user that they have an unsupported subgraph, and tell them how to update their subgraphs so that they work properly.
Here is an example of the console output the user would see (based on the repro project):

Testing status
Manual testing according to the repro steps in the bug.
N.b., On this Yamato run, the bokken farm was having certificate issues on the OSX agent (also present on master at branch-off for this PR)
Comments to reviewers
Notes for the reviewers you have assigned.