Skip to content

[HDRP] fix shader warning in Ambient Occlusoin #5881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2021
Merged

[HDRP] fix shader warning in Ambient Occlusoin #5881

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions com.unity.render-pipelines.high-definition/Runtime/Material/MaterialEvaluation.hlsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,9 @@ void AccumulateIndirectLighting(IndirectLighting src, inout AggregateLighting ds
struct AmbientOcclusionFactor
{
real3 indirectAmbientOcclusion;
real directAmbientOcclusion;
real3 directAmbientOcclusion;
real3 indirectSpecularOcclusion;
real directSpecularOcclusion;
real3 directSpecularOcclusion;
};

// Get screen space ambient occlusion only:
Expand Down Expand Up @@ -106,8 +106,8 @@ void GetScreenSpaceAmbientOcclusionMultibounce(float2 positionSS, float NdotV, f
aoFactor.indirectSpecularOcclusion = GTAOMultiBounce(min(specularOcclusionFromData, indirectSpecularOcclusion), fresnel0);
aoFactor.indirectAmbientOcclusion = GTAOMultiBounce(min(ambientOcclusionFromData, indirectAmbientOcclusion), diffuseColor);
// Note: when affecting direct lighting we don't used the fake bounce.
aoFactor.directSpecularOcclusion = directSpecularOcclusion;
aoFactor.directAmbientOcclusion = directAmbientOcclusion;
aoFactor.directSpecularOcclusion = directSpecularOcclusion.xxx;
aoFactor.directAmbientOcclusion = directAmbientOcclusion.xxx;
}

void ApplyAmbientOcclusionFactor(AmbientOcclusionFactor aoFactor, inout BuiltinData builtinData, inout AggregateLighting lighting)
Expand Down