Skip to content

replace buildfarm image with package-ci/mac:stable #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2020
Merged

replace buildfarm image with package-ci/mac:stable #590

merged 1 commit into from
May 25, 2020

Conversation

kivistikliis
Copy link
Contributor

Purpose of this PR
Replace buildfarm/mac:stable images with package-ci/mac:stable for packages and templates, because buildfarm images have been deprecated and upm-ci jobs fail for mac when using them.

Links

Yamato: (Select your branch) https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics/tree/yamato%252Fupm-ci-mac-image

Comments to reviewers

Pack and test all packages job with new images: https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics/tree/yamato%252Fupm-ci-mac-image/.yamato%252Fupm-ci-packages.yml%2523all_package_ci_fast-trunk/2290362/job/pipeline

@kivistikliis kivistikliis requested a review from sophiaaar May 25, 2020 08:56
@kivistikliis kivistikliis requested a review from a team as a code owner May 25, 2020 08:56
@kivistikliis
Copy link
Contributor Author

Cancelled ABV (and therefore Yamato is red) since the pack and test all packages job was tested separately and is already included within ABV.

@sophiaaar
Copy link
Contributor

looks good to me!

@sophiaaar sophiaaar merged commit d7f9a9e into master May 25, 2020
@sophiaaar sophiaaar deleted the yamato/upm-ci-mac-image branch May 25, 2020 09:24
@sophiaaar
Copy link
Contributor

backports will be handled by @theo-pnv

theopnv pushed a commit that referenced this pull request May 25, 2020
@theo-at-unity
[Yamato] replace buildfarm image with package-ci/mac:stable for packa…
524f229 
…ges and templates (#590)
@theopnv theopnv mentioned this pull request May 25, 2020
Merged
theopnv pushed a commit that referenced this pull request May 25, 2020
@theo-at-unity
[Yamato] replace buildfarm image with package-ci/mac:stable for packa…
31677a3 
…ges and templates (#590)
@theopnv theopnv mentioned this pull request May 25, 2020
Merged
theopnv pushed a commit that referenced this pull request May 25, 2020
@theo-at-unity
[Yamato] replace buildfarm image with package-ci/mac:stable for packa…
1d9776d 
…ges and templates (#590)
@theopnv theopnv mentioned this pull request May 25, 2020
Merged
sophiaaar pushed a commit that referenced this pull request May 25, 2020
[Yamato] replace buildfarm image with package-ci/mac:stable for packa…
1c35800 
…ges and templates (#590) (#595)

Co-authored-by: Liis Kivistik <liis.kivistik@unity3d.com>
sophiaaar pushed a commit that referenced this pull request May 25, 2020
@theo-at-unity
[Yamato] replace buildfarm image with package-ci/mac:stable for packa…
8f385b9 
…ges and templates (#590) (#592)

Co-authored-by: Liis Kivistik <liis.kivistik@unity3d.com>
Co-authored-by: Théo Penavaire <theo.penavaire@unity3d.com>
sophiaaar pushed a commit that referenced this pull request May 25, 2020
[Yamato] replace buildfarm image with package-ci/mac:stable for packa…
429eb95 
…ges and templates (#590) (#594)

Co-authored-by: Liis Kivistik <liis.kivistik@unity3d.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sophiaaar sophiaaar sophiaaar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backported-7.x backported-8.x backported-9.x yamato

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kivistikliis @sophiaaar