Skip to content

Conversation

arttu-peltonen
Copy link
Contributor

@arttu-peltonen arttu-peltonen commented Oct 14, 2021

Purpose of this PR

EDIT: I had misunderstood the code, the UI change is not necessary because iOS works the same as other platforms. I've repurposed this PR to just be about improving the tests.

  1. Add actionable warning message that informs user why they are seeing only 0 in each value. This is because FrameTimingManager is not available.
    Note: This message is be rarely visible because for most platforms, FrameTimingManager is always enabled in development builds (and Rendering Debugger is only accessible in development builds). However, the message should appear on iOS development builds when Frame Timing Stats is disabled in Player Settings. What it should look like:

  2. Enable RT profiler unit test in player builds, now that there is player-visible API for checking whether FrameTimingManager is enabled. Before this API was added, these tests had to be disabled in player builds because it was not possible to query if frame timings are available.


Testing status

EDIT: UI changes are removed, so manual testing is not necessary here, I will focus on ensuring Yamato is fine with the test changes.

Please verify the following things using an iOS development build:
1) The warning message is shown and the frame stats are 0, when Frame Timing Stats is disabled in Player Settings.
2) The warning message is not shown and the frame stats show valid numbers, when Frame Timing Stats is enabled in Player Settings.

NOTE: Testing requires building latest version of trunk (feature relies on new trunk API)

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

SRP Core
You could run ABV on your branch before merging your PR, but it will start A LOT of jobs. Please be responsible about it and run it only when you feel the PR is ready:
/.yamato%252F_abv.yml%2523all_project_ci_trunk
Be aware that any modifications to the Core package impacts everyone in the Graphics repo so please discuss the PR with your lead.

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions github-actions bot added the SRP label Oct 14, 2021
Base automatically changed from srp/realtimeprofiler-proto to master October 22, 2021 09:21
@arttu-peltonen arttu-peltonen force-pushed the rpw/debugui-warning-frametiming-disabled branch from 778aac6 to 1d61dd4 Compare October 22, 2021 11:22
@arttu-peltonen arttu-peltonen force-pushed the rpw/debugui-warning-frametiming-disabled branch from 1d61dd4 to 19749cc Compare November 8, 2021 13:23
@arttu-peltonen arttu-peltonen marked this pull request as ready for review November 8, 2021 13:46
@arttu-peltonen arttu-peltonen self-assigned this Nov 8, 2021
Copy link
Contributor

@alex-vazquez alex-vazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

Copy link

@ernestasKupciunas ernestasKupciunas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't work as intended. Even the FrameTimingStats checkbox was disabled in the Player Settings, I was still able to see the stats and no warning appeared.
Tested with:
VLNQA00292, iPad Air3, SoC: A12, iOS: 13.2.3

2022.1.0a15.2209
Revision: trunk 49120632d05b
Built: Tue, 09 Nov 2021 06:50:39 GMT

@arttu-peltonen
Copy link
Contributor Author

@ernestasKupciunas thanks for checking. I've investigated and it appears I've misunderstood, and there's no need for this warning after all, iOS works the same as other platform which is great. I'll remove the UI change from this, and repurpose this PR to just be about improving the unit test, which I still want to do.

@arttu-peltonen arttu-peltonen changed the title [WIP] Show warning message in Debug UI if FrameTimingManager is disabled Enable FrameTimingManager tests in standalone builds Nov 10, 2021
@arttu-peltonen arttu-peltonen force-pushed the rpw/debugui-warning-frametiming-disabled branch from 19749cc to da47afa Compare November 10, 2021 08:32
- This allows runtime profiler tests to run in Player builds, now that there's api to query it.
@arttu-peltonen arttu-peltonen force-pushed the rpw/debugui-warning-frametiming-disabled branch from da47afa to 0c6226c Compare November 11, 2021 13:15
@arttu-peltonen arttu-peltonen marked this pull request as draft November 12, 2021 07:29
@arttu-peltonen arttu-peltonen force-pushed the rpw/debugui-warning-frametiming-disabled branch from 0c6226c to 27b2a88 Compare November 12, 2021 07:52
@arttu-peltonen arttu-peltonen marked this pull request as ready for review November 16, 2021 07:56
@arttu-peltonen
Copy link
Contributor Author

This PR is now ready, in the end I'm just modifying the runtimeprofiler tests:

Checked that the test is now skipped on Linux and passes on other platforms.

Copy link
Contributor

@alex-vazquez alex-vazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks, good. We should create a task to reenable the test for Linux Platform?

@arttu-peltonen
Copy link
Contributor Author

"Restoring test on Linux" tracked here: https://jira.unity3d.com/browse/XPIPELINE-451

@arttu-peltonen arttu-peltonen merged commit b439405 into master Nov 16, 2021
@arttu-peltonen arttu-peltonen deleted the rpw/debugui-warning-frametiming-disabled branch November 16, 2021 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants