[RP Workflows] Fix serialization of generic enums on the Rendering Debugger #6093
Conversation
|
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. SRP Core Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
| if (state == null || | ||
| state.GetValue() == null || | ||
| !(DebugManager.instance.GetItem(queryPath) is DebugUI.IValueField widget)) | ||
| if (!(DebugManager.instance.GetItem(queryPath) is DebugUI.IValueField widget)) |
There was a problem hiding this comment.
Why removing the state null check ? It is used below.
This can break the code if called with null state.
There was a problem hiding this comment.
with the changes won't make the state to be null anymore
There was a problem hiding this comment.
Ha sorry I was thinking it was public :D;;
So it is ok
| if (state == null || | ||
| state.GetValue() == null || | ||
| !(DebugManager.instance.GetItem(queryPath) is DebugUI.IValueField widget)) | ||
| if (!(DebugManager.instance.GetItem(queryPath) is DebugUI.IValueField widget)) |
There was a problem hiding this comment.
Ha sorry I was thinking it was public :D;;
So it is ok
alex-vazquez
changed the title
4 participants
Purpose of this PR
https://fogbugz.unity3d.com/f/cases/1371353/
Testing status
1- Open Rendering Debbuger
2- Hide it with another tab
3- Do assembly reload
4- Perform an action
5-Undo last action
6-See that the issue does not happen, and the Enum Values are recovered.
Comments to reviewers
Notes for the reviewers you have assigned.