Skip to content

Conversation

Nightmask3
Copy link
Contributor


Purpose of this PR

This PR updates the ShaderGraph dependency on the Searcher package to 4.9.1, which solves these bugs in 2021.2:

https://fogbugz.unity3d.com/f/cases/1375251
https://fogbugz.unity3d.com/f/cases/1375250
https://fogbugz.unity3d.com/f/cases/1375249
https://fogbugz.unity3d.com/f/cases/1375248


Testing status

Manually verified that the above bugs no longer repro.


Comments to reviewers

This PR will have to be merged in post this Ono PR getting merged into the core editor code: https://ono.unity3d.com/unity/unity/pull-request/133681/_/2021.2/searcher/update-to-4_9_1

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

Shader Graph
/jobDefinition/.yamato%252Fall-shadergraph.yml%2523PR_ShaderGraph_2021.2
Depending on your PR, you may also want
/jobDefinition/.yamato%252Fall-shadergraph_builtin_foundation.yml%2523PR_ShaderGraph_BuiltIn_Foundation_2021.2
/jobDefinition/.yamato%2Fall-shadergraph_builtin_lighting.yml%23PR_ShaderGraph_BuiltIn_Lighting_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@Nightmask3 Nightmask3 marked this pull request as ready for review October 25, 2021 23:01
@Nightmask3 Nightmask3 requested a review from a team as a code owner October 25, 2021 23:01
@Nightmask3 Nightmask3 changed the title [2021.2][ShaderGraph] Bump Searcher package dependency to 4.9.1 [Backport][2021.2][ShaderGraph] Bump Searcher package dependency to 4.9.1 Oct 25, 2021
Copy link
Contributor

@GrantLamb-Unity GrantLamb-Unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran some basic tests around verifying the fixes. Also had a zoom conversation with Sai about some general process questions when it comes to how the SG team tests their work. Based on these I'm approving 👍

@Nightmask3
Copy link
Contributor Author

Not sure whats going on with the test results being reported above in the PR itself, but on Yamato this is the result of the first test run:
image

Reran the one failing test leg and dependencies and it also passed:
image

@marctem marctem merged commit 106aac9 into 2021.2/staging Oct 29, 2021
@marctem marctem deleted the 2021.2/fix-searcher-bugs-backport branch October 29, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants