Update URP materials - Fix API is in the wrong state issue #6331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. URP Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
|
It appears that you made a non-draft PR! |
phi-lira
approved these changes
Nov 18, 2021
phi-lira
pushed a commit
that referenced
this pull request
Nov 18, 2021
This was referenced Nov 18, 2021
Merged
ellioman
added a commit
that referenced
this pull request
Jan 28, 2022
* URP quality improvements (#6090) * "Add Renderer Feature" menu now uses the same menu as "Volume Overrides" * Universal Renderer help URL * Add page hash to help URL helper * Allow renderer features to use HelpURLAttribute and add it for SSAO, Decal, and Render Objects * Remove Name input for SSAO and Screen Space Shadows * Fix help URL for URP asset * Update change log * Fix change log * Remove `Attribute` suffix from attribute usage * Add docs for FilterWindow.Show * Move GetHelpURL to DocumentationUtils * Improve TryGetHelpURL interface * Upgrade test materials and assets for premultiplied blend parity. (#6326) * Upgraded Runtime/Materials/*.mat files. * Foundation CommonAssets/ *.mat files upgrade. * Foundation Scenes/ .mat files upgrade. * Foundation Scenes/ .renderTexture files upgrade. * Lighting CommonAssets/ .mat upgrade. * Lighting EditMode Assets .mat files upgrade. * Lighting Scenes/ .mat files upgrade. * Lighting Scenes/ .renderTexture files upgrade. * Terrain CommonAssets/ .mat files upgrade. * Terrain Scenes/ .mat files upgrade. * PostProcessing CommonAssets/ .mat files upgrade. * PostProcessing Scenes/ .mat files upgrade. * Making intermediate render textures scale with the RenderScale setting when a camera renders to a texture (#6274) * Fix API is in the wrong state issue (#6331) * BatchRendererGroup Test Projects Automation (#6276) * update reference images * Update HDRP failing test reference images * Add HDRP Linux Vulkan test images * Rename UniversalHybridTest to BatchRendererGroup_URP * Move vulkan win ref images to None folder * Rename HDRP_HybridTests to BatchRenderGroup_HDRP * replace hybrid with BRG and add to nightly * Fix HDRP project name type * fix typo * Add .meta files of added reference images * remove playmode_xr * Update RenderBRG.cs scripts from hrnext-bugfix * Update BrgGameojbects hdrp reference images after master merge * Add vulkan to HDRP brg windows * use gpu for build, remove osx from ci * apply patch from the [Yamato] Formatting job * add BRG to nightly [skip ci] * remove the hybrid projects from repoconfig Co-authored-by: MingWai Chan <mingwai@unity3d.com> Co-authored-by: Tomas Kiniulis <tomas.kiniulis@unity3d.com> Co-authored-by: Sophia <sophia@unity3d.com> * Tweaked bloom quality options * made new settings additional * Updated docs * Improving the Bloom Test scene so that it tests Max Iterations, Downscale, Dirt Texture and Dirt Intensity * Renaming the Downscale enum to BloomDownscaleMode * Deprecating the skipIterations variable * Changelog * Changelog * Updating bloom reference image for Android GLES3 Co-authored-by: Peter Bay Bastian <pbbastian@users.noreply.github.com> Co-authored-by: Erik Hakala <59870743+eh-unity@users.noreply.github.com> Co-authored-by: Théo Penavaire <theo-pnv@users.noreply.github.com> Co-authored-by: mingwai <cinight@users.noreply.github.com> Co-authored-by: MingWai Chan <mingwai@unity3d.com> Co-authored-by: Tomas Kiniulis <tomas.kiniulis@unity3d.com> Co-authored-by: Sophia <sophia@unity3d.com> Co-authored-by: Andrem <andrem@unity3d.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fix Api is in the wrong state issue reported here, when running srp2core tests.
Testing status
Safety net + checking that the changes are fixing the issue when cherry-picking them on the srp2core branch.