Skip to content

[HDRP] Graphics test for cascaded shadows with custom projection matrix #6443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 8, 2022
Merged

[HDRP] Graphics test for cascaded shadows with custom projection matrix #6443

merged 10 commits into from
Feb 8, 2022

Conversation

pmavridis
Copy link
Contributor

@pmavridis pmavridis commented Dec 1, 2021 •
edited
Loading

Purpose of this PR

This is a graphics test for a fix that will land in Trunk with this C++ PR: https://ono.unity3d.com/unity/unity/pull-request/136374/_/graphics/bugfix/1366218

Testing status

Before the fix:
image

After the fix:
image

Comments to reviewers

Please merge after the C++ PR lands.

@pmavridis pmavridis added the HDRP label Dec 1, 2021
@github-actions
Copy link

github-actions bot commented Dec 1, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23PR_HDRP_trunk
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@pmavridis
Add missing meta file
11d5daa
@pmavridis
Merge remote-tracking branch 'origin/master' into HDRP/graphicstest_c…
8c64fd9 
…ase1366218

# Conflicts:
#	TestProjects/HDRP_Tests/ProjectSettings/EditorBuildSettings.asset
@pmavridis
Copy link
Contributor Author

pmavridis commented Feb 7, 2022 •
edited
Loading

Trunk PR was merged, running yamato to create screenshots for all platforms.

@sebastienlagarde
Copy link
Contributor

@pmavridis you need to merge master before re-running the test, otherwise you will not get the right bianry

@pmavridis pmavridis marked this pull request as ready for review February 8, 2022 11:22
@sebastienlagarde sebastienlagarde merged commit f919158 into master Feb 8, 2022
@sebastienlagarde sebastienlagarde deleted the HDRP/graphicstest_case1366218 branch February 8, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sebastienlagarde sebastienlagarde sebastienlagarde approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

HDRP testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pmavridis @sebastienlagarde