Skip to content

Conversation

phi-lira
Copy link
Contributor

Guide : https://github.com/Unity-Technologies/Graphics/blob/master/.github/pr-read.png.md

Display Addon : https://userstyles.org/styles/182991/unity-graphics-pr-readme

Purpose of this PR

Testing status

Manual Tests

  • Tested manually myself. Transparent fix was tested using scene 105 and by changing from Opaque to Transparent queues. Also changed the Queue Offset to negative numbers. Works as expected.
  • Tested OpenGL Core issue by opening DoF test scene in OpenGL Core. It works as expected.

Automated Tests

  • We have to figure out how to add test automation to material editor.
  • OpenGL Core PR has OpenGL test target enabled. (master)

Links

Yamato: (Select your branch) https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics

Any test projects or documents to go with this to help reviewers?

Comments to reviewers

Notes for the reviewers you have assigned.

@phi-lira phi-lira requested a review from a team as a code owner May 28, 2020 13:23
@phi-lira phi-lira requested a review from eh-unity May 28, 2020 13:23
Copy link
Contributor

@ellioman ellioman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@cinight cinight self-requested a review May 28, 2020 13:30
Copy link
Contributor

@cinight cinight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified transparent material issue

@phi-lira phi-lira merged commit bd75e12 into 7.x.x/release May 28, 2020
@phi-lira phi-lira deleted the 7.x.x/universal/additional-fixes branch May 28, 2020 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants