Skip to content

Fixed errors spamming when in player mode due to ray tracing light cluster debug view (case 1390471). #6820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 27, 2022
Merged

Fixed errors spamming when in player mode due to ray tracing light cluster debug view (case 1390471). #6820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9af35e6
Fixed errors spamming when in player mode due to ray tracing light cl…
anisunity Jan 24, 2022
39043a9
Merge branch 'master' into HDRP/fix-1390471
anisunity Jan 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed Correlated Color Temperature not being applied in Player builds for Enlighten realtime GI lights (case 1370438);
- Fixed artifacts on gpu light culling when the frustum near and far are very spread out (case 1386436)
- Fixed missing unit in ray tracing related tooltips and docs (case 1397491).
- Fixed errors spamming when in player mode due to ray tracing light cluster debug view (case 1390471).

## [14.0.0] - 2021-11-17

Expand Down
8 changes: 6 additions & 2 deletions ...r-pipelines.high-definition/Runtime/RenderPipeline/Raytracing/HDRaytracingLightCluster.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,7 +621,7 @@ class LightClusterDebugPassData
public int lightClusterDebugKernel;
public Vector3 clusterCellSize;
public Material debugMaterial;
public ComputeBuffer lightCluster;
public ComputeBufferHandle lightCluster;
public ComputeShader lightClusterDebugCS;

public TextureHandle depthStencilBuffer;
Expand All @@ -631,6 +631,10 @@ class LightClusterDebugPassData

public void EvaluateClusterDebugView(RenderGraph renderGraph, HDCamera hdCamera, TextureHandle depthStencilBuffer, TextureHandle depthPyramid)
{
// TODO: Investigate why this behavior causes a leak in player mode only.
if (FullScreenDebugMode.LightCluster != m_RenderPipeline.m_CurrentDebugDisplaySettings.data.fullScreenDebugMode)
return;

TextureHandle debugTexture;
using (var builder = renderGraph.AddRenderPass<LightClusterDebugPassData>("Debug Texture for the Light Cluster", out var passData, ProfilingSampler.Get(HDProfileId.RaytracingDebugCluster)))
{
Expand All @@ -639,7 +643,7 @@ public void EvaluateClusterDebugView(RenderGraph renderGraph, HDCamera hdCamera,
passData.texWidth = hdCamera.actualWidth;
passData.texHeight = hdCamera.actualHeight;
passData.clusterCellSize = clusterCellSize;
passData.lightCluster = m_LightCluster;
passData.lightCluster = builder.ReadComputeBuffer(renderGraph.ImportComputeBuffer(m_LightCluster));
passData.lightClusterDebugCS = m_RenderPipelineRayTracingResources.lightClusterDebugCS;
passData.lightClusterDebugKernel = passData.lightClusterDebugCS.FindKernel("DebugLightCluster");
passData.debugMaterial = m_DebugMaterial;
Expand Down