Skip to content

Conversation

@zezba9000
Copy link

Please read the Contributing guide before making a PR.

Checklist for PR maker

  • [N/A should be upstream as well ] Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • Have you updated the changelog? Each package has a CHANGELOG.md file.
  • Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the Docs team contacts sheet.
  • Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Purpose of this PR

Missing ShaderGraph nodes for doing custom GPU Vertex skinning shaders.


Testing status

Wrote custom URP ShaderGraph shader that does GPU Vertex Skinning to verify function.
image


Comments to reviewers

This is highly useful for Quest / VR situation where Unity's build in SkinnedMeshRenderer can cause notable performance degradation. Exposing BoneIndexNode & BoneWeightNode in URP ShaderGraph allow for special / platform optimized skinned shaders to be made.

@zezba9000 zezba9000 requested a review from a team as a code owner April 6, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants