Skip to content

Conversation

@megh-jagad
Copy link
Contributor

@megh-jagad megh-jagad commented Jan 27, 2025

Please read the Contributing guide before making a PR.

Checklist for PR maker

  • Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • Have you updated the changelog? Each package has a CHANGELOG.md file.
  • Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the Docs team contacts sheet.
  • Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Purpose of this PR

Update input system to 1.12.0 for 6000.1


Testing status

Ran the test runner. No issues


Comments to reviewers

Copy link
Contributor

@lyndon-unity lyndon-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the change updates the necessary manifest and package files and project settings to be input system only. Happy to approve - made a small comment about the changelog message and alternative PR


### Changed

- Upgrade input system version to 1.12.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We added a litte more in the alternative PR.

  • Upgrade input system version to 1.12.0 so that a warning message is shown on platforms which require additional platform specific input system packages to be installed.
  • Set InputHandler to input system exclusive

(See https://github.com/Unity-Technologies/Graphics/pull/8118/files)

@megh-jagad megh-jagad requested a review from Pauliusd01 January 28, 2025 00:57
@theopnv
Copy link
Contributor

theopnv commented Jan 31, 2025

Just running the templates suite here before hitting merge https://unity-ci.cds.internal.unity3d.com/job/46317295.

@theopnv theopnv merged commit 504e639 into master Jan 31, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants