Add dispatch of navigation events for InputForUI #1667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfreire-unity
changed the title
jimon
reviewed
Apr 5, 2023
Packages/com.unity.inputsystem/InputSystem/Plugins/InputForUI/InputSystemProvider.cs
Show resolved
Hide resolved
benoit-alain
approved these changes
Apr 5, 2023
benoit-alain
left a comment
benoit-alain
left a comment
There was a problem hiding this comment.
Seems good, we can continue adding on this if something's missing (next/previous repeat?).
jfreire-unity
added a commit
that referenced
this pull request
Apr 12, 2023
* Add dispatch of navigation events * Fix formatting * Unifies GetEventSource() for callback context and devices * Use DispatchFromCallback and clean todos
jfreire-unity
added a commit
that referenced
this pull request
May 23, 2023
* Adding dependency to a provider package * wip * wip * wip * wip * wip * wip * sorting of events and filtering of pointer events * pointer indices * more robust scroll events * forgot to reset state flags * trying out to use touchscreen for finger index * removing leftovers * Add dispatch of navigation events for InputForUI (#1667) * Add dispatch of navigation events * Fix formatting * Unifies GetEventSource() for callback context and devices * Use DispatchFromCallback and clean todos * InputForUI: Add repetition for Next/Previous navigation events (#1670) * Update renaming of Event.CompareType * Add Next/Previous navigation events repetition Currently it doesn't deal with keys other than tab and shift+tab. Discussion needs to happen to allow configuration for this with the Input System. * Set seenTouchEvents and seenTouchEvents for missing control paths and events (#1674) * fix compilation errors when opening InputSystem project * fix compilation errors when opening project in older editors * Bootstrap InputForUI provider only if enabled in the PlayerSettings (ISX-1386) * Fix null reference errors by not initializing InputForUI in the editor (ISX-1397) * Fix to avoid PointerEvents from Mouse when using Touch * Reverse bool logic of resetSeenEventsOnUpdate * Remove debug logs * Fix PointerEvents with same pointerIndex for all fingers * fix InputForUI not being bootstrapped in IL2CPP builds (ISX-1424) * fix for deprecated warning * fix for unused variable warning * run formatting tool * modify naming to conform to coding convention * fix for running tests in standalone builds * Remove commented code and add missing comment --------- Co-authored-by: Dmytro Ivanov <dmytro@unity3d.com> Co-authored-by: João <joao.freire@unity3d.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dispatches
NavigationEventssuch asLeft,Right,Up,Downfor both Mouse and Keyboard, as they are part of the_moveActionsetup by the default input actions asset.NextandPreviouscurrently are only setup for Keyboard, as there is not default action that hastabbindings. A new action was created for this.Notes
If this approach works and is good enough for now, I'll refactor the code a bit to avoid having less repetition for
NavigationEventsin bothInputManagerProvider(not part of this repository) andInputSystemProvider.