CHANGE: Add automated testing setup for InputForUI #1680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfreire-unity
changed the base branch from
develop
to
dmytro/common-input-api-for-ui
lyndon-unity
approved these changes
May 19, 2023
Collaborator
lyndon-unity
left a comment
lyndon-unity
left a comment
There was a problem hiding this comment.
Looks like a sensible addition.
Obviously wait for the main provider to land (or merge into that branch)
Collaborator
|
That said this is failing tests which are related so it looks like it needs a fix |
lyndon-unity
requested changes
May 19, 2023
Collaborator
Author
|
@lyndon-unity Yeah, this PR requires some |
jfreire-unity
force-pushed
the
input-for-ui/add-automated-tests
branch
from
890bc6d to
7063aa7
Compare
lyndon-unity
approved these changes
May 23, 2023
Collaborator
lyndon-unity
left a comment
lyndon-unity
left a comment
There was a problem hiding this comment.
Seems reasonable, happy to see test coverage expanding
| // Start touch and move mouse to the same position to replicate the issue of duplicated Mouse events for | ||
| // Touch events on Windows. | ||
| BeginTouch(1, new Vector2(100f, 0.5f)); | ||
| Move(mouse.position, new Vector2(100f, 0.5f)); |
Collaborator
There was a problem hiding this comment.
Should we be testing a mouse click too here ?
jfreire-unity
force-pushed
the
input-for-ui/add-automated-tests
branch
from
884f0b6 to
4dca8fe
Compare
Collaborator
Author
|
Holding this for after the 1.6.0 release since the |
jfreire-unity
force-pushed
the
input-for-ui/add-automated-tests
branch
from
4dca8fe to
bb96940
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the test setup for the InputSystemProvider that is used on the 2023.2+ InputForUI module.
Changes made
Sets up the Unity project to test the InputForUI module with the InputSystemProvider implementation.
Adds a basic test with a mouse to validate that the test setup is working and that events are being dispatched.
Notes
This depends on #1679 and should not be merged before
Checklist
Before review:
Changed,Fixed,Addedsections.([case %number%](https://issuetracker.unity3d.com/issues/...)).During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.