Modified onIMECompositionChange documentation to bring clarity to intended usage
#1755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Secticide
added
work in progress
duckets
approved these changes
Sep 28, 2023
ekcoh
approved these changes
Sep 28, 2023
Collaborator
ekcoh
left a comment
ekcoh
left a comment
There was a problem hiding this comment.
Approving this one, lets merge it as soon as CI is working again. Doc checks might pick something up but looks good so likely not.
Collaborator
|
@Secticide I believe you just need to resolve conflict in CHANGELOG.md now and lets CI rerun this branch. Then you may merge it to develop. |
Secticide
force-pushed
the
ISXB-628-IME-Composition-Event-Docs
branch
3 times, most recently
from
e09a767 to
54defba
Compare
…iance on blank string events for submission and reset
Secticide
force-pushed
the
ISXB-628-IME-Composition-Event-Docs
branch
from
54defba to
73117ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When investigating a user's issue with the
onIMECompositionChangeevent with a specific IME on Windows 10 (Korean), we noticed that there are cases where the blank event is not fired to signify the submission or resetting of the composition. The more consistent way to use this events is to use the IME Composition Change event to display the text that is currently being edited and rely on theonTextInputevent for submission (resetting can be handled by listening for a new composition event and updating the displayed text accordingly).The specific line that likely caused the user to expect (and therefore rely on) the empty string event is as follows:
Changes made
onIMECompositionChangeevent documentation to better point users to intended usageNotes
This is a work in progress PR with the intention of iterating on the documentation wording.