Skip to content

Conversation

@graham-huws
Copy link
Collaborator

@graham-huws graham-huws commented Jan 18, 2024

Description

Fix for ISX-1726 - Include asset name in window title, matching behaviour from before UITK work.

Changes made

As above.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • FogBugz ticket attached, example ([case %number%](https://issuetracker.unity3d.com/issues/...)).
    • FogBugz is marked as "Resolved" with next release version correctly set.
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

@graham-huws graham-huws changed the title Readd asset name to window title (ISX-1726). FIX: Readd asset name to window title (ISX-1726). Jan 18, 2024
@graham-huws graham-huws marked this pull request as ready for review January 18, 2024 13:36
@Pauliusd01
Copy link
Collaborator

Pauliusd01 commented Jan 18, 2024

The position of the unsaved changes star symbol (*) is different from what it was before
image

Copy link
Collaborator

@Pauliusd01 Pauliusd01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the minor change mentioned above seems good to me. Checked: that ProjectWideActions is unaffected, IMGUI version is unaffected, unsaved changes * symbol shows up correctly, checked that unusual symbols (chinese, cyrillic characters) and long names don't break the titling.

@graham-huws
Copy link
Collaborator Author

graham-huws commented Jan 18, 2024

The position of the unsaved changes star symbol (*) is different from what it was before

Thanks, fixed in d7b7bbd.

@graham-huws graham-huws force-pushed the ISX-1726-window-asset-name branch from 552f1e7 to d7b7bbd Compare January 18, 2024 14:35
@graham-huws graham-huws changed the title FIX: Readd asset name to window title (ISX-1726). FIX: Re-add asset name to window title (ISX-1726). Jan 18, 2024
Copy link
Collaborator

@ritamerkl ritamerkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't check it in the editor - Looks good to me.

@graham-huws graham-huws merged commit dac00ca into develop Jan 22, 2024
@graham-huws graham-huws deleted the ISX-1726-window-asset-name branch January 22, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants