Skip to content

Conversation

@graham-huws
Copy link
Collaborator

@graham-huws graham-huws commented Jan 18, 2024

Description

Fix for ISX-1482 - Don't leave the Save Asset button as highlighted (focused) after clicking.

Changes made

As above.

Notes

Relating to my comments in the code, tabbing through the UI should highlight each object in turn per accessibility guidelines (https://unity.slack.com/archives/C3414V4UV/p1689871437531979?thread_ts=1689865302.307989&cid=C3414V4UV), so it's actually a bug that not everything gets highlighted when tabbing through the UI. But it's also one that seems to be extremely widespread across the whole editor, so probably not a top priority for us...

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • FogBugz ticket attached, example ([case %number%](https://issuetracker.unity3d.com/issues/...)).
    • FogBugz is marked as "Resolved" with next release version correctly set.
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

@graham-huws graham-huws force-pushed the ISX-1482-save-button-pressed branch from 0473cd3 to 4ebf6c3 Compare January 18, 2024 14:35
@graham-huws graham-huws force-pushed the ISX-1482-save-button-pressed branch from 4ebf6c3 to 1889850 Compare January 18, 2024 14:49
@graham-huws graham-huws changed the title Fix selection highlight lingering after clicking save button (ISX-1482). FIX: selection highlight lingering after clicking save button (ISX-1482). Jan 18, 2024
@graham-huws graham-huws changed the title FIX: selection highlight lingering after clicking save button (ISX-1482). FIX: Selection highlight lingering after clicking save button (ISX-1482). Jan 18, 2024
Copy link
Collaborator

@Pauliusd01 Pauliusd01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, checked that the highlight disappears correctly on mouse click and tab+enter, double checked the IMGUI version that it still functions the same.

@graham-huws graham-huws marked this pull request as ready for review January 18, 2024 15:15
Copy link
Collaborator

@lyndon-unity lyndon-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change looks reasonable (as does the change log tidy up)

@graham-huws graham-huws merged commit 96f5aa7 into develop Jan 22, 2024
@graham-huws graham-huws deleted the ISX-1482-save-button-pressed branch January 22, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants