Skip to content

Conversation

@tspiller
Copy link
Collaborator

Description

On Windows the '&' character is considered an accelerator character and will always be stripped. Since the ControlScheme menu isn't creating hotkeys, it can be safely assumed that they are meant to be text and escape the character for MenuItem.

Testing status & QA

Local testing / automated tests

Overall Product Risks

Windows Editor only

  • Complexity: 0
  • Halo Effect: 0

Comments to reviewers

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@tspiller tspiller marked this pull request as ready for review November 20, 2024 14:45
@tspiller tspiller requested a review from ekcoh November 20, 2024 14:45
Copy link
Collaborator

@ekcoh ekcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, suggest adding @Pauliusd01 for QA perspective.

@ekcoh
Copy link
Collaborator

ekcoh commented Nov 21, 2024

Also seem to need an update from develop.

@ekcoh ekcoh requested a review from Pauliusd01 November 21, 2024 15:17
Copy link
Collaborator

@Pauliusd01 Pauliusd01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, checked && as well as other non standard symbols and did not have issues seeing the correct name in the UI or switching schemes via script

@tspiller tspiller merged commit 0a13378 into develop Nov 22, 2024
77 checks passed
@tspiller tspiller deleted the isxb-1109-control-scheme-menu-ampersand branch November 22, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants