- 
                Notifications
    You must be signed in to change notification settings 
- Fork 327
DOCS: Improved script API docs of InputAction.CallbackContext #2064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | I noticed this one has malformed xmldoc so need to revisit that | 
              
                    lyndon-unity
  
              
              requested changes
              
                  
                    Dec 2, 2024 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small correction needed in the example code
        
          
                Packages/com.unity.inputsystem/InputSystem/Actions/InputAction.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                Packages/com.unity.inputsystem/InputSystem/Actions/InputAction.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
      
              
                    ritamerkl
  
              
              approved these changes
              
                  
                    Dec 2, 2024 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, mainly minor comments
        
          
                Packages/com.unity.inputsystem/InputSystem/Actions/InputAction.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                Packages/com.unity.inputsystem/InputSystem/Actions/InputAction.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                Packages/com.unity.inputsystem/InputSystem/Actions/InputAction.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
      
              
                    lyndon-unity
  
              
              approved these changes
              
                  
                    Dec 3, 2024 
                  
              
              
            
            
              
                    duckets
  
              
              approved these changes
              
                  
                    Dec 9, 2024 
                  
              
              
            
            
        
          
                Packages/com.unity.inputsystem/InputSystem/Actions/InputAction.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                Packages/com.unity.inputsystem/InputSystem/Actions/InputAction.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
      
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Description
Improved script API Doscs of InputAction.CallbackContext:
Testing status & QA
Reviewed generated XML docs in IDE inspector (Rider)
Generated docs via package docs tool.
Overall Product Risks
Comments to reviewers
Check language, compliance and example.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: