-
Notifications
You must be signed in to change notification settings - Fork 328
FIX: Update sample materials to be URP/HDRP compatible [TBD] #2223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## develop #2223 +/- ##
===========================================
+ Coverage 68.14% 76.70% +8.55%
===========================================
Files 367 465 +98
Lines 53685 87920 +34235
===========================================
+ Hits 36584 67436 +30852
- Misses 17101 20484 +3383 Flags with carried forward coverage won't be shown. Click here to find out more.
... and 98 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Getting shader errors on build on 6.3 at the moment |
Might be that this is still in flight but would recommend updating CHANGELOG to reflect these changes. |
@Pauliusd01 Please update this PR with latest develop to get critical CI fix from #2260. I do not dare doing it for you since the branch has conflicts I may not understand. |
Description
Switches out sample materials to a shadergraph one that is cross compatible between URP/HDRP. One caveat is that if someone wants to use it with the old built in render pipeline they have to install the shadergraph package. Also, this adds a dependency to our own main project as it is a built in render pipeline project.
Note: Shadergraph version added is the one offered by 22.3 which seems to update just fine across our supported editors
Testing status & QA
Import changed samples locally through the package manager, run every scene in player and play mode in a new URP & HDRP project. (22.3, 6.0 & trunk)
Overall Product Risks
Comments to reviewers
None yet, TBD
Checklist
Before review:
Changed
,Fixed
,Added
sections.Area_CanDoX
,Area_CanDoX_EvenIfYIsTheCase
,Area_WhenIDoX_AndYHappens_ThisIsTheResult
.During merge:
NEW: ___
.FIX: ___
.DOCS: ___
.CHANGE: ___
.RELEASE: 1.1.0-preview.3
.After merge: