- 
                Notifications
    You must be signed in to change notification settings 
- Fork 396
feat: multiple video capturer #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    Change the access modifiers from public to internal or protected.
add AudioStreamTrack.
public modify to internal.
# Conflicts: # Assets/Scripts/RenderStreaming.cs
…ream CaptureAudioStream
todo: 1.create multiple resolution texture for nvEncoder. 2.Abstract out a base class BaseEncoder. Derive AmdEncoder and softEncoder.
…erStreaming into feat/merge_multiple_video_capturer # Conflicts: # Assets/Scripts/RenderStreaming.cs # Packages/com.unity.webrtc/Runtime/Srcipts/MediaStream.cs # Packages/com.unity.webrtc/Runtime/Srcipts/WebRTC.cs # Packages/com.unity.webrtc/Tests/Runtime/MediaStreamTest.cs # Plugin/WebRTCPlugin/Callback.cpp # Plugin/WebRTCPlugin/Context.h # Plugin/WebRTCPlugin/WebRTCPlugin.cpp # WebApp/public/scripts/video-player.js
| It has compile error because  | 
              
                    koseyile
  
              
              approved these changes
              
                  
                    Sep 6, 2019 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
What is this?
Merge this PR to
devbranch.TODO
Manage inputs from multiple users
Each camera are controlled with
SimpleCameraController. Currently, this component can only control one camera. We should fix the component to be able to control each camera.We should modify
RemoteInputclass. It should not be singleton.Input systemhas the User Management feature. We try this feature to enable receiving input message from multiple browsers.Refactor Javascript class to assign streams to multiple videos
video-player.jsis a temporary state to support multiple videos.We should refactor this code to make it easy to use for developers.