Skip to content

Conversation

@karasusan
Copy link
Collaborator

@karasusan karasusan commented Aug 27, 2019

What is this?

Merge this PR to dev branch.

Aug-27-2019 17-17-54

TODO

Manage inputs from multiple users

Each camera are controlled with SimpleCameraController. Currently, this component can only control one camera. We should fix the component to be able to control each camera.

We should modify RemoteInput class. It should not be singleton.

Input system has the User Management feature. We try this feature to enable receiving input message from multiple browsers.

Refactor Javascript class to assign streams to multiple videos

video-player.js is a temporary state to support multiple videos.
We should refactor this code to make it easy to use for developers.

koseyile and others added 29 commits July 1, 2019 10:16
Change the access modifiers  from public to internal or protected.
add AudioStreamTrack.
public modify to internal.
# Conflicts:
#	Assets/Scripts/RenderStreaming.cs
todo:
1.create multiple resolution texture for nvEncoder.
2.Abstract out a base class BaseEncoder. Derive AmdEncoder and softEncoder.
…erStreaming into feat/merge_multiple_video_capturer

# Conflicts:
#	Assets/Scripts/RenderStreaming.cs
#	Packages/com.unity.webrtc/Runtime/Srcipts/MediaStream.cs
#	Packages/com.unity.webrtc/Runtime/Srcipts/WebRTC.cs
#	Packages/com.unity.webrtc/Tests/Runtime/MediaStreamTest.cs
#	Plugin/WebRTCPlugin/Callback.cpp
#	Plugin/WebRTCPlugin/Context.h
#	Plugin/WebRTCPlugin/WebRTCPlugin.cpp
#	WebApp/public/scripts/video-player.js
@karasusan
Copy link
Collaborator Author

It has compile error because RenderStreamingHDRPSimple.unitypackage use old WebRTC API.

@karasusan karasusan changed the title WIP: multiple video capturer feat: multiple video capturer Aug 28, 2019
@karasusan karasusan requested a review from koseyile September 5, 2019 01:54
Copy link
Contributor

@koseyile koseyile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karasusan karasusan merged commit fa0e335 into dev Sep 6, 2019
@karasusan karasusan deleted the feat/merge_multiple_video_capturer branch September 6, 2019 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants