-
Notifications
You must be signed in to change notification settings - Fork 4.4k
improve the migration doc #1155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
docs/Migrating.md
Outdated
|
|
||
| ### Unity API | ||
|
|
||
| * Discrete Actions now have branches. You can now specify concurrent discrete |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is not part of the PR - but we ought to better explain branches or at a minimum add a reference.
docs/Migrating.md
Outdated
| * Discrete Actions now have branches. You can now specify concurrent discrete | ||
| actions. You will need to update the Brain Parameters in the Brain Inspector | ||
| in all your environments. | ||
| in all your environments that uses discrete actions. Refer to the [discrete action documentation](Learning-Environment-Design-Agents.md#discrete-action-space) for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use not uses
|
@mmattar I've resolved all of the comments. |
docs/Migrating.md
Outdated
| ### Unity API | ||
|
|
||
| * Discrete Actions now have branches. You can now specify concurrent discrete | ||
| * Discrete Actions now have [branches](https://arxiv.org/abs/1711.08946). You can now specify concurrent discrete |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"now have" --> "now use"
No description provided.