.gitignor *.xml breaks MarathonEnvs #1209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @Sohojoe, Can you please update to the latest |
Contributor
|
@Sohojoe Sorry about the confusion---we actually just synced up our hotfix branch so you shouldn't have to do anything on your end. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MarathonEnvs uses .xml files. If a developer takes the ML-Agents .gitignor when working with MarathonEnvs their .xml files will not be added to git and they will not be aware of this.
From what I see there is no need to aggressively ignore all *.xml files (and if there is, it would be better to limit this to those paths)
To test I...
No new .xml files where generated/needed to be ignored