Support both 32-bit and 64-bit types in UnityEnvironment #1471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awjuliani
approved these changes
Dec 11, 2018
harperj
force-pushed
the
develop-baselines-fix
branch
from
cef083c to
ee81496
Compare
We check for the single brain case in UnityEnvironment by checking for applicable non-dict types in the step arguments. However for ints and floats we just use `np.int_` and `np.float_` for the check, which are the defaults for your system. This means if you are using an application (like baselines in #1448) which uses the wrong int/float size an error will be thrown. This change explicitly allows both 32 and 64-bit numbers.
harperj
force-pushed
the
develop-baselines-fix
branch
from
ee81496 to
286aed4
Compare
Contributor
Author
|
I rebased this over the |
Contributor
|
Hi @harperj If you've tested it feel free to merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We check for the single brain case in UnityEnvironment by checking
for applicable non-dict types in the step arguments. However for ints
and floats we just use
np.int_andnp.float_for the check, whichare the defaults for your system.
This means if you are using an application (like baselines in #1448)
which uses the wrong int/float size an error will be thrown. This
change explicitly allows both 32 and 64-bit numbers.