Release 0.7 Fix gym_unity Tests #1744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Would it be possible to have a separate method that generates the Mock objects ? This way we can reuse them later in other future tests. |
Contributor
Author
|
Moved the creation of mocks into helper functions. |
ervteng
force-pushed
the
release-fixgymtest
branch
from
2b9f979 to
cd5b508
Compare
ervteng
force-pushed
the
release-fixgymtest
branch
from
cd5b508 to
367239b
Compare
LeSphax
pushed a commit
to LeSphax/ml-agents-1
that referenced
this pull request
May 3, 2020
* Change gym-unity tests to use Mock instead of MockCommunicator * move creation of mock objects into helper functions * Fix comment * Fix Codacy errors * Fix ending whitespace * Minor fixes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed tests to use Mock entirely rather than using MockCommunicator.