Skip to content

Conversation

@ervteng
Copy link
Contributor

@ervteng ervteng commented Apr 5, 2019

No description provided.

@ervteng ervteng requested review from harperj and vincentpierre April 5, 2019 02:36
@ervteng ervteng closed this Apr 5, 2019
@ervteng ervteng reopened this Apr 5, 2019
@ervteng
Copy link
Contributor Author

ervteng commented Apr 5, 2019

Note: On Docker it does save .nn but we get this error.

Process Process-1: Traceback (most recent call last): File "/usr/local/lib/python3.6/multiprocessing/process.py", line 258, in _bootstrap self.run() File "/usr/local/lib/python3.6/multiprocessing/process.py", line 93, in run self._target(*self._args, **self._kwargs) File "/ml-agents-envs/mlagents/envs/subprocess_environment.py", line 70, in worker env.close() File "/ml-agents-envs/mlagents/envs/environment.py", line 467, in close raise UnityEnvironmentException("No Unity environment is loaded.") mlagents.envs.exception.UnityEnvironmentException: No Unity environment is loaded.

Copy link
Contributor

@harperj harperj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change itself looks good, if we're seeing double .close() happening it's probably just because close is also being called in the finally: clause. We could just remove one of the calls.

@harperj harperj merged commit 3902463 into release-v0.8 Apr 8, 2019
@Unity-Technologies Unity-Technologies deleted a comment Apr 8, 2019
@ervteng ervteng deleted the release-v0.8-fixclose branch July 9, 2019 22:01
LeSphax pushed a commit to LeSphax/ml-agents-1 that referenced this pull request May 3, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants