Barracuda 0.2.1 -> develop #2049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentpierre
approved these changes
Jun 6, 2019
Contributor
vincentpierre
left a comment
vincentpierre
left a comment
There was a problem hiding this comment.
Works for me. I want to wait on @ervteng and his results on the banana collector.
ervteng
approved these changes
Jun 11, 2019
Contributor
|
I was able to get BananaCollector to work after the latest commit. Thanks @mantasp! |
chriselion
reviewed
Jun 12, 2019
| public BarracudaRecurrentInputGenerator(int memoriesCount, int memoryIndex) | ||
| { | ||
| this.firstHalf = firstHalf; | ||
| this.memoriesCount = memoriesCount; |
Contributor
There was a problem hiding this comment.
@mantasp I'm seeing a warning in the editor regarding this:
Assets/ML-Agents/Scripts/InferenceBrain/GeneratorImpl.cs(123,21): warning CS0414: The private field `MLAgents.InferenceBrain.BarracudaRecurrentInputGenerator.memoriesCount' is assigned but its value is never used
OK to remove it?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded Barracuda to version 0.2.1.
Lots of improvements: performance, memory usage, etc.