Fix the CSV file reward lagging way behind the actual rewards #2120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the CSV file's mean rewards would lag much behind the rest of the code since this buffer was never cleared.
xiaomaogy
approved these changes
Jun 11, 2019
sankalp04
pushed a commit
that referenced
this pull request
Jun 21, 2019
Before the CSV file's mean rewards would lag much behind the rest of the code since this buffer was never cleared.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We aren't clearing the List called
self.cumulative_returns_since_policy_updatewhen we update the policy. This is used to compute the mean rewards to write to CSV, and it just gets longer and longer through training.This PR clears it when we update the policy.