Skip to content

Fixed the import issue #2158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 21, 2019
Merged

Fixed the import issue #2158

merged 3 commits into from
Jun 21, 2019

Conversation

@xiaomaogy
Copy link
Contributor

@xiaomaogy xiaomaogy commented Jun 20, 2019

No description provided.

@xiaomaogy xiaomaogy requested a review from ervteng June 20, 2019 22:57
@ervteng
Copy link
Contributor

ervteng commented Jun 20, 2019 •
edited
Loading

After some digging - looks like the structure we are using is the native namespace package introduced in Python 3.3. (we don't have an init.py in mlagents/).

One thing we can do is replace the setup.py packages= with packages=find_namespace_packages(exclude=["*.tests", "*.tests.*", "tests.*", "tests"]). I've tested this and it does successfully find the trainers. This would mean we won't have to keep adding new packages to this list.

xiaomaogy
xiaomaogy commented Jun 21, 2019
View reviewed changes
ml-agents/setup.py Outdated
"mlagents.trainers",
"mlagents.trainers.bc",
"mlagents.trainers.ppo",
], # Required
Copy link
Contributor Author

@xiaomaogy xiaomaogy Jun 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~

Copy link
Contributor

@chriselion chriselion Jun 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@chriselion chriselion Jun 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @ervteng's solution is better though.

@xiaomaogy xiaomaogy merged commit 4859a10 into release-v0.8.2 Jun 21, 2019
@xiaomaogy xiaomaogy deleted the release-v0.8.2-import-fix branch June 21, 2019 02:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ervteng ervteng Awaiting requested review from ervteng

1 more reviewer

@chriselion chriselion chriselion left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xiaomaogy @ervteng @chriselion