Tick version number for 0.9 #2331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ervteng
commented
Jul 25, 2019
ervteng
commented
- Tick version for Python packages
- Tick communication API to API-9
chriselion
reviewed
Jul 25, 2019
| public BroadcastHub broadcastHub = new BroadcastHub(); | ||
|
|
||
| private const string kApiVersion = "API-8"; | ||
| private const string kApiVersion = "API-9"; |
Contributor
There was a problem hiding this comment.
What's the procedure on these? We didn't actually change the API for this release, right?
Contributor
There was a problem hiding this comment.
We usually just change the API along with the major release (even though they are still compatible).
xiaomaogy
approved these changes
Jul 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.