Add Migrating.md for v0.9 #2347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ervteng
commented
Jul 26, 2019
ervteng
commented
- Change to reward signals
- Step count for multiple environments
harperj
reviewed
Jul 26, 2019
| #### Steps to Migrate | ||
| * If you were overriding any of these following parameters in your config file, remove them | ||
| from the top-level config and follow the steps below: | ||
| * `gamma` - Define a new `extrinsic` reward signal and set it's `gamma` to your new gamma. |
Contributor
There was a problem hiding this comment.
Suggested change
| * `gamma` - Define a new `extrinsic` reward signal and set it's `gamma` to your new gamma. | |
| * `gamma` - Define a new `extrinsic` reward signal and set its `gamma` to your new gamma. |
harperj
approved these changes
Jul 26, 2019
xiaomaogy
reviewed
Jul 26, 2019
|
|
||
| ### Important Changes | ||
| * We have changed the way reward signals (including Curiosity) are defined in the | ||
| `trainer_config.yaml`. |
Contributor
There was a problem hiding this comment.
Maybe instead of saying "it has changed in the trainer_config.yaml" (which is one of the yaml file that doesn't have any gail configured), say something like "we have changed the way reward signals (..) are defined in the configuration file, you can refer to gail_config.yaml as an example".
Contributor
There was a problem hiding this comment.
Please ignore my previous comment. I just realized that this isn't explaining anything regarding the new features, just how to migrate from using the old features.
xiaomaogy
approved these changes
Jul 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.