ML-Agents Branding & Color Updates #2583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Hunter-Unity
commented
Sep 18, 2019
Hunter-Unity
commented
- Dark Theme
- Colors are now standardized across all environments
- BananaCollector env & scripts renamed to FoodCollector
- Unity branding added to each scene
- Hallway now uses symbol targets instead of color targets
- Added template scene with standard colors/styles/prefabs
- 3DBall env now balances ball on agent's head
|
|
Hunter-Unity
requested review from
awjuliani,
surfnerd,
vincentpierre and
xiaomaogy
Contributor
|
looks like there are bunch of files with |
vincentpierre
previously requested changes
Sep 18, 2019
Contributor
vincentpierre
left a comment
vincentpierre
left a comment
There was a problem hiding this comment.
I have no idea how you did it, but the tag manager asset was not changed in this PR even though I can see the new tags.
UnitySDK/Assets/ML-Agents/Editor/Tests/DiscreteActionOutputApplierTest.cs.meta~develop
Outdated
Show resolved
Hide resolved
UnitySDK/Assets/ML-Agents/Examples/SharedAssets/Prefabs/Canvas - Watermark.prefab
Show resolved
Hide resolved
UnitySDK/Assets/ML-Agents/Examples/Soccer/Materials/Textures/SoccerPitchAL (1).png.meta
Show resolved
Hide resolved
…gies/ml-agents into hh/new_env_styles
UnitySDK/Assets/ML-Agents/Examples/SharedAssets/Materials/GridMatBall 1.mat
Outdated
Show resolved
Hide resolved
UnitySDK/Assets/ML-Agents/Examples/SharedAssets/Prefabs/Directional Light.prefab
Show resolved
Hide resolved
walker collects physics observations so stacked states are not needed
xiaomaogy
reviewed
Sep 20, 2019
Contributor
|
Also maybe you could sign the CLA @Hunter-Unity ? |
UnitySDK/Assets/ML-Agents/Examples/Crawler/Scripts/CrawlerAgent.cs
Outdated
Show resolved
Hide resolved
…uncersteps Increase bouncer steps
ervteng
dismissed
vincentpierre’s stale review
Changes addressed (9/23/2019)
ervteng
approved these changes
Sep 23, 2019
Contributor
ervteng
left a comment
ervteng
left a comment
There was a problem hiding this comment.
Ship it! TODO: Update models from latest runs for Crawler and Bouncer
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.