small mypy cleanup #2637
Merged
small mypy cleanup #2637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 27, 2019 18:09
chriselion
commented
Sep 28, 2019
| self.training_buffer.update_buffer.save_to_file(file_object) | ||
|
|
||
| def load_replay_buffer(self) -> Buffer: | ||
| def load_replay_buffer(self) -> None: |
Contributor
Author
There was a problem hiding this comment.
Fixed the return type here, which also lets you not import Buffer
ervteng
reviewed
Sep 30, 2019
ervteng
pushed a commit
that referenced
this pull request
Oct 9, 2019
* small mypy cleanup * sac cleanup * types for ppo policy init
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to get
--namespace-packagesin mypy working for our project (it currently hits an internal assert). In the meantime, here are a few things that flagged.