Change docs and ipynb to reflect new import path for UnityEnvironment #2673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriselion
reviewed
Oct 3, 2019
docs/Migrating.md
Outdated
| * `UnitySDK/Assets/ML-Agents/Scripts/Communicator.cs` and its class `Communicator` have been renamed to `UnitySDK/Assets/ML-Agents/Scripts/ICommunicator.cs` and `ICommunicator` respectively. | ||
| * The `SpaceType` Enums `discrete`, and `continuous` have been renamed to `Discrete` and `Continuous`. | ||
| * We have removed the `Done` call as well as the capacity to set `Max Steps` on the Academy. Therefore an AcademyReset will never be triggered from C# (only from Python). If you want to reset the simulation after a fixed number of steps, or when an event in the simulation occurs, we recommend looking at our multi-agent example environments (such as BananaCollector). In our examples, groups of Agents can be reset through an "Area" that can reset groups of Agents. | ||
| * The import for `UnityEnvironment` in the low-level Python API has changed. If you are using the Python API, change `from mlagents.envs import UnityEnvironment` to `from mlagents.envs.environment import UnityEnvironment`. |
Contributor
There was a problem hiding this comment.
This isn't quite accurate. UnityEnvironment is still in ml-agents-envs/mlagents/envs/environment.py, but an import that made it look like it was also in another location was removed.
Contributor
There was a problem hiding this comment.
Here's the actual line that changed:
https://github.com/Unity-Technologies/ml-agents/pull/2584/files#diff-829b0b865c5a9e2ea85ed647b3012702L4
Contributor
Author
There was a problem hiding this comment.
Ah, I see - should it read something like "The import for mlagents.envs.UnityEnvironment was removed"?
chriselion
previously approved these changes
Oct 4, 2019
chriselion
approved these changes
Oct 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like my editor also removed a bunch of white spaces.