handle None action outputs #2988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentpierre
approved these changes
Nov 27, 2019
Contributor
|
I think it is fairly elegant |
ervteng
approved these changes
Nov 27, 2019
Contributor
ervteng
left a comment
ervteng
left a comment
There was a problem hiding this comment.
Still curious what root cause is (and why the previous action change would affect this at all?) but the fix here looks clean.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started happening in #2913, but only shows up in the WallJump scene. It happens eventually when running the full scene, but happens right away if only 2 of the areas are enabled; we believe it's due to all of the agents only using one of the two brains.
There might be a cleaner fix for this, but we'll merge this today for the release if a better solution doesn't present itself.