Change AgentProcessor logic to fix memory leak #3383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vincentpierre
left a comment
vincentpierre
left a comment
There was a problem hiding this comment.
Can we have some training results on bouncer and hallway to see if there are regressions ?
| if not self.last_step_result[_gid][0].done: | ||
| if "action" in take_action_outputs: | ||
| self.policy.save_previous_action( | ||
| [global_id], take_action_outputs["action"] |
| self.policy.save_previous_action( | ||
| previous_action.agent_ids, take_action_outputs["action"] | ||
| # Index is needed to grab from last_take_action_outputs | ||
| self.last_step_result[global_id] = ( |
Contributor
Author
There was a problem hiding this comment.
This one needs to be global_id, its in a different loop
Contributor
|
How do you know it works without a test? |
Contributor
Author
Tracking the size of the dicts using example envs (Hallway, Bouncer). Still need to think of a good unit test for this; we need to emulate On-demand decisions |
added 2 commits
February 10, 2020 15:24
Contributor
Author
|
|
Contributor
Author
Added a unit test that checks the basic deleting mechanism between resets. |
Contributor
|
Great, just wanted to make sure we had some checks on it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a recent change, the Agent ID now changes after every episode reset. This caused the dictionary of keys to grow inside the AgentProcessor. This PR cleans up the adding/deletion of items on reset boundaries, so that the dict doesn't grow.