csharp cleanup #3392
Merged
csharp cleanup #3392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 7, 2020 14:51
chriselion
commented
Feb 7, 2020
| [HideInInspector] | ||
| public Rigidbody agentRb; | ||
| SoccerSettings m_SoccerSettings; | ||
| Renderer m_AgentRenderer; |
Contributor
Author
There was a problem hiding this comment.
@andrewcoh A few unused variables from soccer. Just want to make sure there's no plans to bring these back.
Contributor
There was a problem hiding this comment.
Ah I missed this. Good to remove.
chriselion
commented
Feb 7, 2020
| [HideInInspector] | ||
| [SerializeField] | ||
| public int m_TeamID = 0; | ||
| public int m_TeamID; |
Contributor
Author
There was a problem hiding this comment.
This is still public with m_ prefixes. Seems like it needs to be mutable at runtime so it should stay public (or have an accessor)
chriselion
commented
Feb 7, 2020
|
|
||
| public void GiveModel( | ||
| string behaviorName, | ||
| string newBehaviorName, |
Contributor
Author
There was a problem hiding this comment.
Argument name shadowed the behaviorName property
chriselion
commented
Feb 7, 2020
| { | ||
| class TestAgent : Agent | ||
| { | ||
| public AgentAction GetAction() |
Contributor
Author
There was a problem hiding this comment.
Agent has a GetAction now, and this wasn't actually being used.
vincentpierre
approved these changes
Feb 7, 2020
surfnerd
approved these changes
Feb 7, 2020
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply a lot (but not 100%) of Rider's suggestions.