encapsulate the agent mapping operations #3481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentpierre
approved these changes
Feb 21, 2020
added 3 commits
February 21, 2020 17:10
vincentpierre
approved these changes
Feb 22, 2020
| mock_env.return_value.get_step_result.return_value = mock_result | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("mapper_cls", [AgentIdIndexMapper, AgentIdIndexMapperSlow]) |
Contributor
Author
There was a problem hiding this comment.
Do you mean pytest.mark.parametrize, or passing class types as parameters?
chriselion
commented
Feb 24, 2020
| # Make sure it's actually a permutation - needs to contain 0..N-1 with no repeats. | ||
| assert set(permutation) == set(range(0, 4)) | ||
|
|
||
| # For initial agents that were in the initial group, they need to be in the same slot. |
Contributor
Author
There was a problem hiding this comment.
@vincentpierre Is my claim here correct about the new agents? Order shouldn't matter as long as it's consistent, right?
Contributor
There was a problem hiding this comment.
Yes, although anywhere might be confusing. They must replace previously done agents
delete-merged-branch
bot
deleted the
develop-fix-gym-last-reward-cleanup
branch
vincentpierre
added a commit
that referenced
this pull request
Feb 24, 2020
* Fixing #3460 * Addressing comments * Added 2 tests * encapsulate the agent mapping operations (#3481) * encapsulate the agent mapping operations * rename, linear time impl * cleanup * dict.popitem * udpate comments * Update gym-unity/gym_unity/tests/test_gym.py Co-authored-by: Chris Elion <celion@gmail.com>
anupam-142857
pushed a commit
that referenced
this pull request
Feb 26, 2020
* Fixing #3460 * Addressing comments * Added 2 tests * encapsulate the agent mapping operations (#3481) * encapsulate the agent mapping operations * rename, linear time impl * cleanup * dict.popitem * udpate comments * Update gym-unity/gym_unity/tests/test_gym.py Co-authored-by: Chris Elion <celion@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to clean up and encapsulate these operations. If the initial approach sounds good, I think I can make all the operations O(1).