raise errors properly on UnityRegistry #4070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ervteng
reviewed
Jun 4, 2020
| logger.debug( | ||
| f"Attempt {attempt + 1} / {NUMBER_ATTEMPTS} : Failed to download" | ||
| ) | ||
| except Exception: # pylint: disable=W0702 |
Contributor
There was a problem hiding this comment.
Is there a particular exception that is given here when it fails to download?
Contributor
Author
There was a problem hiding this comment.
A lot of things could go wrong : Could have internet problems, zip extraction problems, permission issues, IOErrors...
Contributor
There was a problem hiding this comment.
I suppose ideally we only retry certain things, specifically internet/download problems. But that seems more difficult than it's worth
Contributor
There was a problem hiding this comment.
Maybe we can just change the message to "Failed to download and extract". I also think it should be a warning and not a debug message.
ervteng
approved these changes
Jun 4, 2020
chriselion
approved these changes
Jun 4, 2020
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Raising errors better when something goes wrong when trying to download
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Types of change(s)
Checklist
Other comments