Skip to content

add numpy version to timer metadata, log random seed #4285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2020
Merged

add numpy version to timer metadata, log random seed #4285

merged 1 commit into from
Jul 30, 2020

Conversation

@chriselion
Copy link
Contributor

@chriselion chriselion commented Jul 30, 2020

Proposed change(s)

  • add numpy version to timer metadata
  • log random seed if it's not specified, to make reproducing random failures easier

andrewcoh
andrewcoh approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@andrewcoh andrewcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call to output the run seed.

@chriselion chriselion merged commit 086a869 into master Jul 30, 2020
@delete-merged-branch delete-merged-branch bot deleted the more-diagnostics branch July 30, 2020 01:20
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@andrewcoh andrewcoh andrewcoh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chriselion @andrewcoh