Skip to content

Conversation

@chriselion
Copy link
Contributor

@chriselion chriselion commented Sep 15, 2020

Proposed change(s)

Followup from a discussion with @zookae - On Windows, saving e.g. 3DBall would put the executable at 3DBall\UnityEnvironment.exe. That would mean running with --env=3DBall would not fix the executable. This improves the logic by adding an extra check if the existing one fails: search for *.exe under the env directory, and exclude UnityCrashHandler*.exe

Types of change(s)

  • Other (Small improvement)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@chriselion chriselion requested a review from ervteng September 15, 2020 01:30
Copy link
Contributor

@ervteng ervteng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works 👍

@chriselion chriselion merged commit c54197a into release_7_branch Sep 15, 2020
@delete-merged-branch delete-merged-branch bot deleted the r7_exe_path_win branch September 15, 2020 20:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants